feat(pdo): add with-transaction macro#32
Merged
Conversation
Related to #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
pdo/with-transactionmacro so callers stop hand-writing the begin/try/commit/rollback dance:Semantics (per #20):
(begin conn)before the body;(commit conn)on normal completion; macro evaluates to the last body form.\Throwable:(rollback conn)then re-throw the original.(in-transaction conn)is already true, the body runs inline - no nested begin/commit (v1, no savepoints; documented).Hygiene
connis evaluated once into an auto-gensymconn#;result#/e#are gensym'd. Expansion callsbegin/commit/rollback/in-transactionvia syntax-quote qualification, so it resolves correctly from any caller namespace (proven by the tests living inphel.pdo-test).docs/recipes.mdtransactions section + CHANGELOG updated.Polish pass: no refactor needed - single
let/if/tryform, no duplication.composer testgreen (56 assertions).Closes #20